[v 2.3.0] RUBY-1104 Add CursorReaper for periodically sending kill cursor operations #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estolfo
force-pushed
the
RUBY-1104-gc-cursor
branch
2 times, most recently
from
f350676 to
216c8ff
Compare
estolfo
changed the title
estolfo
force-pushed
the
RUBY-1104-gc-cursor
branch
from
5aa389c to
3c41713
Compare
estolfo
changed the title
estolfo
force-pushed
the
RUBY-1104-gc-cursor
branch
from
79dcee4 to
e7a4562
Compare
Contributor
Author
|
@durran |
estolfo
force-pushed
the
RUBY-1104-gc-cursor
branch
2 times, most recently
from
3918c5b to
e7e33e1
Compare
estolfo
force-pushed
the
RUBY-1104-gc-cursor
branch
from
e7e33e1 to
467305f
Compare
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Consolidate cursor ids into one op per namespace + server in CursorReaper#kill_cursors(not going to do thisUse read_with_one_retry method instead of read_with_retry (in sep PR right now)Must add disconnect method to CursorReaperCheck if cursor is active at time of sending kill cursors op instead of when it is scheduled